Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-connect): add env for specifying the WC v1 bridge #2820

Merged
merged 3 commits into from
Jul 10, 2023
Merged

feat(wallet-connect): add env for specifying the WC v1 bridge #2820

merged 3 commits into from
Jul 10, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jul 10, 2023 •
edited
Loading

Summary

Allows to modify the wallet connect bridge from an environment variable

To Test

  1. Go to https://swap-dev-git-add-env-for-wallet-connect-v1-cowswap.vercel.app/#/1/swap/WETH

  2. Click to connect with wallet connect

image
  1. Copy the code
image
  1. Inspect the URL, it should have the right bridge in the params. I've modified the envs so, just heck it matches:
image

You should see
image

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

🌃 Cosmos ↗︎

@anxolin anxolin requested review from ahhda and a team July 10, 2023 11:07
@anxolin anxolin added the RELEASE Included in the release that is being closed label Jul 10, 2023
@anxolin anxolin marked this pull request as ready for review July 10, 2023 11:48
elena-zh
elena-zh approved these changes Jul 10, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works according to the description

@anxolin anxolin requested a review from alfetopito July 10, 2023 13:08
@anxolin anxolin merged commit 045caa3 into hotfix/1.40.6 Jul 10, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
@alfetopito alfetopito deleted the add-env-for-wallet-connect-v1 branch July 11, 2023 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@elena-zh elena-zh elena-zh approved these changes

@ahhda ahhda Awaiting requested review from ahhda

Assignees
No one assigned
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anxolin @alfetopito @elena-zh