feat(twap): add missing tooltips #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
approved these changes
Jul 11, 2023
| limitPriceTooltip: ( | ||
| <> | ||
| If CoW Swap cannot get this price or better after fees and slippage are taken into account, your TWAP | ||
| will not execute. CoW Swap will <strong>always</strong> improve on this price if possible. |
There was a problem hiding this comment.
@MindyCoW maybe this one can be a bit more positive? in the other part we were taking about price protection, so maybe we should mention sth like "CoW Swap will protect your order from executing at an unfavorable price"...
elena-zh
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing tooltips
On TWAP review modal fields
On order receipt modal (Safe fields)
To Test