chore: make pixel events more resilient #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
approved these changes
Jul 12, 2023
nenadV91
approved these changes
Jul 12, 2023
elena-zh
requested changes
Jul 12, 2023
|
Hey @anxolin , it appears that the issue is also reproducible on Prod, so it can't be related to the upcoming release. |
alfetopito
approved these changes
Jul 12, 2023
|
I still address comments, I just want to consolidate the PRs. Pls @elena-zh let me know if it worked for you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pixels and any other analytics in the app should not break the user flow in case of an error.
This PR makes sure that if we have an error reporting Pixel (facebook, twitter, etc), we just log it and it doesn't propagate.
Additionally, this PR enables the pixel reporting for PRODUCTION and ENS (well, in the PR is enabled for testing purposes, but will be disabled before merging as stated in the code comment)
This PR tries to solve the issue reported by Elena:
To Test
@elena-zh can you check if this is fixing the issue?