fix(twap): avoid sending env as undefined to getOrder query
#2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, instead of the default behaviour, the SDK defaults to `barn` endpoint
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
commented
Jul 12, 2023
| : undefined), | ||
| } | ||
|
|
||
| return orderBookApi.getOrder(orderId, contextOverride) |
There was a problem hiding this comment.
There was a problem hiding this comment.
We should fix in the SDK too, should default to prod
anxolin
approved these changes
Jul 12, 2023
| : undefined), | ||
| } | ||
|
|
||
| return orderBookApi.getOrder(orderId, contextOverride) |
There was a problem hiding this comment.
We should fix in the SDK too, should default to prod
|
merging, just to consolidate all these pending PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid sending
envasundefinedto getOrder queryWithout this, instead of the default behaviour, the SDK defaults to
barnendpointTo Test
api.cow.fiendpointstaging, there should be no /orders/ requests tobarn.api.cow.fiendpoint