Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TWAP): update content based on orders type #2915

Merged
merged 3 commits into from
Jul 19, 2023
Merged

feat(TWAP): update content based on orders type #2915

merged 3 commits into from
Jul 19, 2023

Conversation

nenadV91
Copy link
Contributor

Summary

Fixes #2910

  • Fixes the issues mentioned in the issue related by changing some order table content based on the order types.
  • Also renames one type from LimitOrderActions to OrderActions since its shared now

To test

  • Test that the scenarios mentioned in the issue are fixed

@vercel
Copy link

vercel bot commented Jul 19, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 0:56am

@nenadV91 nenadV91 requested review from a team July 19, 2023 12:21
@nenadV91 nenadV91 added the TWAP label Jul 19, 2023
elena-zh
elena-zh approved these changes Jul 19, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nenadV91 nenadV91 merged commit 1e1a9bc into develop Jul 19, 2023
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
@alfetopito alfetopito deleted the 2910/update-order-table branch July 19, 2023 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
TWAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.43]Update texts for Your orders table on Advanced orders page
3 participants
@nenadV91 @shoom3301 @elena-zh