feat(twap): fetch first 200 transactions using pagination #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
reviewed
Aug 3, 2023
Merged
alfetopito
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important! Change the target branch before merging!
Fixes #2642 #2993
To fetch Safe transactions we use
@safe-global/api-kit, exactly:safeApiKit.getAllTransactions(safeAddress).By default, it returns only the last 20 transactions. Unfortunately, the limit is hardcoded on the backend, so we can't set limit=200 and fetch all at once.
Anyway,
getAllTransactions()method returns an URL for the next batch, so we can fetch as many as we want using pagination.How the fetching works now:
Every 15 seconds we make 10 requests by 20 transactions (total = 200).
Just in case, I've added
100msdelay between requests.