test(fiatAmount): test UsdPricesUpdater #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
reviewed
Aug 30, 2023
apps/cowswap-frontend/src/modules/usdAmount/updaters/UsdPricesUpdater.test.tsx
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/updaters/UsdPricesUpdater.test.tsx
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/updaters/UsdPricesUpdater.test.tsx
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/usdAmount/updaters/UsdPricesUpdater.tsx
Outdated
Show resolved
Hide resolved
shoom3301
commented
Aug 30, 2023
| Maximum Sold: ${trade.fee?.feeAsCurrency && trade.maximumAmountIn(allowedSlippage).toExact()} | ||
| ` | ||
| ) | ||
| function parseIndependentFieldURLParameter(urlParam: any): Field { |
There was a problem hiding this comment.
Just moved functions from hooks.tsx using auto refactoring.
There was a problem hiding this comment.
To fix circular dependency problem
There was a problem hiding this comment.
What do you mean by auto refactoring?
shoom3301
commented
Aug 30, 2023
| @@ -15,11 +15,12 @@ import { | |||
| switchCurrencies, | |||
| typeInput, | |||
| } from 'legacy/state/swap/actions' | |||
| import { queryParametersToSwapState } from 'legacy/state/swap/hooks' | |||
There was a problem hiding this comment.
Here I broke Circular dependency.
reducer and hooks were in a circle
alfetopito
approved these changes
Aug 30, 2023
… fix/fiat-amount-api-2 # Conflicts: # apps/cowswap-frontend/src/common/hooks/useGetSurplusFiatValue.ts # apps/cowswap-frontend/src/common/hooks/useRateInfoParams.ts # apps/cowswap-frontend/src/common/pure/ExecutionPrice/hooks/useExecutionPriceFiat.ts # apps/cowswap-frontend/src/legacy/components/Tokens/FiatBalanceCell.tsx # apps/cowswap-frontend/src/legacy/hooks/usePriceImpact/useFiatValuePriceImpact.ts # apps/cowswap-frontend/src/modules/account/containers/AccountDetails/SurplusCard.tsx # apps/cowswap-frontend/src/modules/limitOrders/pure/ExecutionPriceTooltip/index.tsx # apps/cowswap-frontend/src/modules/swap/containers/SwapWidget/index.tsx # apps/cowswap-frontend/src/modules/swap/state/useSwapDerivedState.ts # apps/cowswap-frontend/src/modules/trade/containers/TradeBasicConfirmDetails/index.tsx # apps/cowswap-frontend/src/modules/trade/hooks/useBuildTradeDerivedState.ts # apps/cowswap-frontend/src/modules/trade/hooks/useTradeParsedAmounts.ts # apps/cowswap-frontend/src/modules/trade/updaters/PriceImpactUpdater.tsx # apps/cowswap-frontend/src/modules/tradeQuote/hooks/useTradeQuoteFeeFiatAmount.ts
…l/cowswap into fix/fiat-amount-api-unit-tests
… fix/fiat-amount-api-unit-tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.