Permit styles [Modal/Stepper/IconSpinner] #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
reviewed
Sep 1, 2023
| content = <span />; | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Just an idea how to write it shorter:
<Wrapper size={size} spinnerWidth={spinnerWidth} bgColor={bgColor}>
{(() => {
if (currency) {
return <CurrencyLogo currency={currency} size="100%" />
} else if (image) {
return <img src={image} alt="Spinning icon" width={size} height={size} />
} else if (children) {
return <span>{children}</span>
}
return <span />
})()}
</Wrapper>
There was a problem hiding this comment.
Thank you for the suggestion, updated!
shoom3301
reviewed
Sep 1, 2023
| dotBorderColor?: string | ||
| } | ||
|
|
||
| const stateStyles = { |
There was a problem hiding this comment.
Please, specify a type for the const:
interface StepStyles {
dotColor: string
dotBorderColor: string
labelColor: string
}
const stateStyles: Record<StepState, StepStyles> = {
alfetopito
approved these changes
Sep 1, 2023
shoom3301
approved these changes
Sep 4, 2023
* feat: optimize IconSpinner * feat: optimize * feat: add ENUM
|
Something is wrong with the types, the build is failing
|
alfetopito
reviewed
Sep 5, 2023
| margin: auto; | ||
|
|
||
| > path { | ||
| fill: var(--cow-color-text2); |
There was a problem hiding this comment.
Here the enum would be used:
Suggested change
| fill: var(--cow-color-text2); | |
| fill: var(${ColorTypes.COLOR_TEXT_2}); |
Comment on lines
+156
to
+158
| background: var(--cow-container-bg-01); | ||
| border-radius: var(--cow-border-radius-normal); | ||
| box-shadow: var(--cow-box-shadow-normal); |
There was a problem hiding this comment.
And here
Suggested change
| background: var(--cow-container-bg-01); | |
| border-radius: var(--cow-border-radius-normal); | |
| box-shadow: var(--cow-box-shadow-normal); | |
| background: var(${ColorTypes.CONTAINER_BG_01}); | |
| border-radius: var(${ColorTypes.BORDER_RADIUS_NORMAL}); | |
| box-shadow: var(${ColorTypes.BOX_SHADOW_NORMAL}); |
And so on
Comment on lines
+404
to
+409
| --cow-color-border: var(--cow-color-grey); | ||
| --cow-container-bg-01: ${({ theme }) => theme.bg1}; | ||
| --cow-modal-backdrop: var(--cow-color-text1-opacity-25); | ||
| --cow-border-radius-normal: 24px; | ||
| --cow-padding-normal: 24px; | ||
| --cow-box-shadow-normal: 0 1.5rem 1rem #00000008,0 .75rem .75rem #0000000a,0 .25rem .375rem #0000000d; |
There was a problem hiding this comment.
Here is a base place for their definition, using the same way.
It's just a template string, so it shouldn't add any extra processing/make it slower
Suggested change
| --cow-color-border: var(--cow-color-grey); | |
| --cow-container-bg-01: ${({ theme }) => theme.bg1}; | |
| --cow-modal-backdrop: var(--cow-color-text1-opacity-25); | |
| --cow-border-radius-normal: 24px; | |
| --cow-padding-normal: 24px; | |
| --cow-box-shadow-normal: 0 1.5rem 1rem #00000008,0 .75rem .75rem #0000000a,0 .25rem .375rem #0000000d; | |
| ${ColorTypes.COLOR_BORDER}: var(${ColorTypes.COLOR_GREY}); | |
| --cow-container-bg-01: ${({ theme }) => theme.bg1}; | |
| --cow-modal-backdrop: var(--cow-color-text1-opacity-25); | |
| --cow-border-radius-normal: 24px; | |
| --cow-padding-normal: 24px; | |
| --cow-box-shadow-normal: 0 1.5rem 1rem #00000008,0 .75rem .75rem #0000000a,0 .25rem .375rem #0000000d; |
|
Merging as I'm addressing the ENUMs in #3110 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds updated
ModalStepperandIconSpinnermodules. To be used with the Permit flow. Available on Cosmos.Screen.Recording.2023-08-31.at.15.07.16.mov
Screen.Recording.2023-08-31.at.15.06.20.mov
Screen.Recording.2023-08-31.at.15.06.02.mov