chore: allow enough balance check to return unknown state #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
commented
Sep 5, 2023
apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/OrderRow/index.tsx
Show resolved
Hide resolved
alfetopito
reviewed
Sep 5, 2023
apps/cowswap-frontend/src/modules/tradeQuote/hooks/useQuoteParams.ts
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/utils/getOrderParams.ts
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/tokens/hooks/useEnoughBalance.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Leandro <[email protected]>
alfetopito
reviewed
Sep 5, 2023
apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/utils/getOrderParams.ts
Outdated
Show resolved
Hide resolved
alfetopito
reviewed
Sep 5, 2023
alfetopito
approved these changes
Sep 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handle the
UNKNOWNstate for the check that verifies if the user has enough balance (used for quotes)The app will need to know the balance of the user to decide if its using verified quotes or not.
The balance/allowance is fetched in an async call. Meaning that we can be in a state where we don't know if we have the balance or not.
The app was defaulting to "Yes, it has balance" if we were not sure.
See image below:
Now we handle the undefined case, so we don't use
verifiedquotes:Bonus
I saw we were, in some cases making a request with the same sell token and buy token.
Its only temporal, probably due two the app being on a loading state. We will need to improve this part.
I added a small improvement, so we just don't query the API in this case 4d4b932
To Test
optimalquotes (check network tab)