Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swap): reset state after network changes #3116

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(swap): reset state after network changes #3116

merged 1 commit into from
Sep 7, 2023

Conversation

shoom3301
Copy link
Collaborator

Summary

Fixed #5 from Medium section in #3105

To Test

  1. On Swap page select WETH -> USDC on Mainnet
  2. Change network to Goerli

  • AR: sell token is WETH, but token is USDC

  • ER: sell token is WETH, but token is empty

    Background

The bug was introduced in #3095

@shoom3301 shoom3301 added the RELEASE Included in the release that is being closed label Sep 7, 2023
@shoom3301 shoom3301 requested a review from a team September 7, 2023 06:31
@shoom3301 shoom3301 self-assigned this Sep 7, 2023
@vercel
Copy link

vercel bot commented Sep 7, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview Sep 7, 2023 6:34am

🌃 Cosmos ↗︎

alfetopito
alfetopito approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@alfetopito alfetopito mentioned this pull request Sep 6, 2023
Closed
anxolin
anxolin reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approve, now testing it

@alfetopito alfetopito merged commit 6377f58 into release/1.47.0 Sep 7, 2023
9 checks passed
@alfetopito alfetopito deleted the fix/swap-reset-state-after-n-change branch September 7, 2023 10:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@anxolin anxolin anxolin approved these changes

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @anxolin