Fix flickery modal #3122
Closed
Fix flickery modal #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Errrr.... now I got this instead of the surplus modal |
|
That was on goerli.
|
|
I will close this one. If your PR don't fix the issue i will re-open it back |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to solve the flickery modal. Not working yet, but some progress on the cause.
I believe this hook returns
showSurplustrue/false/null if we start to get errors getting the USD estimation, or if the USD changes so we change from showing to not showing.I believe we should only calculate it once, and we shouln't recompute the surplus in real time to prevent this issues:
cowswap/apps/cowswap-frontend/src/common/hooks/useGetSurplusFiatValue.ts
Line 23 in 2d36b97
I managed to reproduce by adding a random number and returning randomly true/false/null in
cowswap/apps/cowswap-frontend/src/common/hooks/useGetSurplusFiatValue.ts
Line 75 in 2d36b97
See video:
Screen.Recording.2023-09-07.at.18.12.44.mov