feat: allow to change rpc nodes #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
force-pushed
the
allow-to-change-rpc-nodes
branch
from
c0bc09c
to
858c6e9
Compare
anxolin
force-pushed
the
allow-to-change-rpc-nodes
branch
from
29f73df
to
6918a74
Compare
|
Optimistically merging to the hotfix branch. Still pls review the changes @alfetopito @shoom3301 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce the possibility to define your own RPC nodes.
Before, you could only define your own INFURA key. So it was assumed you need to use infura for the RPC nodes.
This PR gives as an alternative, the possibility to define the RPC nodes.
It adapts also the README (it was outdated with some old env vars), and add the new ones.
Test
You can test locally. Review I didn't mess up with the setup, and lastly check it in the preview (should use NodeReal now)
DEMO: https://swap-dev-git-allow-to-change-rpc-nodes-cowswap.vercel.app/