Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5] fix(tokens): fix e2e tests for tokens updates #3193

Merged
merged 9 commits into from
Oct 26, 2023
Merged

[5] fix(tokens): fix e2e tests for tokens updates #3193

merged 9 commits into from
Oct 26, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Oct 10, 2023 •
edited
Loading

Summary

Just updated html anchors for e2e tests and added using NETWORK_URL for json RPC provider.

To Test

Please, test everything in #3201

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev 🔄 Building (Inspect) Visit Preview Oct 26, 2023 0:37am

🌃 Cosmos ↗︎

@shoom3301 shoom3301 self-assigned this Oct 10, 2023
@shoom3301 shoom3301 changed the base branch from refactor/tokens-lib-wiring to refactor/tokens-lib-wiring-5 October 10, 2023 09:43
@shoom3301 shoom3301 requested a review from a team October 11, 2023 12:34
@shoom3301 shoom3301 marked this pull request as ready for review October 11, 2023 12:34
alfetopito
alfetopito approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't check whether this actually fixes anything in this PR... but I trust it does :)

alfetopito
alfetopito approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from this PR, but there's a lint error:

image

@shoom3301
refactor(tokens): remove legacy code (#3194)
6615ef3 
* fix(tokens): fix tokens list loading state (#3201)
@shoom3301 shoom3301 merged commit ad2fe93 into refactor/tokens-lib-wiring-5 Oct 26, 2023
3 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@alfetopito alfetopito deleted the refactor/tokens-e2e-fix branch October 26, 2023 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@anxolin anxolin anxolin approved these changes

Assignees

@shoom3301 shoom3301

Labels
Tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @anxolin