fix(swap): handle errors from order posting API #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
approved these changes
Oct 13, 2023
apps/cowswap-frontend/src/modules/trade/utils/swapErrorHelper.ts
Outdated
Show resolved
Hide resolved
anxolin
reviewed
Oct 13, 2023
apps/cowswap-frontend/src/modules/trade/utils/swapErrorHelper.ts
Outdated
Show resolved
Hide resolved
| const defaultErrorMessage = getProviderErrorMessage(error) | ||
|
|
||
| if (getIsOrderBookTypedError(error)) { | ||
| return capitalizeFirstLetter(error.body?.description) || defaultErrorMessage |
There was a problem hiding this comment.
don't we do the mapping if the type is know?
There was a problem hiding this comment.
I think it's better to show an error as it is. Having this we can change the text on backend side on flight
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3217
Before the fix, we naively used
getProviderErrorMessage()to parse an error. But the error might be an instance ofOrderBookApiError.To Test