fix(swap): don't crash app when token decimals eq 0 #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
commented
Oct 16, 2023
| @@ -101,7 +101,7 @@ export const SwapWarningsTop = React.memo(function (props: SwapWarningsTopProps) | |||
| priceImpact={priceImpact} | |||
| buyingFiatAmount={buyingFiatAmount} | |||
| tradeUrlParams={tradeUrlParams} | |||
| sellAmount={trade?.inputAmount.toFixed(trade?.inputAmount?.currency?.decimals || 18)} | |||
There was a problem hiding this comment.
@alfetopito do you remember why toFixed() was used instead of toExact()?
alfetopito
approved these changes
Oct 17, 2023
alfetopito
force-pushed
the
fix/token-0-dec
branch
from
1221ca9
to
44d22c4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Test