Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor widget configurator #3259

Merged
merged 51 commits into from
Oct 25, 2023
Merged

refactor: refactor widget configurator #3259

merged 51 commits into from
Oct 25, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Oct 22, 2023

Summary

Just refactored the configurator code according to the common rules.

  1. Moved theme-specific code to src/theme
  2. Extracted form control components from the configurator
  3. Added eslint rules from CowSwap Dapp

To Test

  1. Should work the same, just code refactoring

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview Oct 23, 2023 11:18am

🌃 Cosmos ↗︎

@shoom3301 shoom3301 requested a review from a team October 23, 2023 05:09
@shoom3301 shoom3301 marked this pull request as ready for review October 23, 2023 05:09
@shoom3301 shoom3301 changed the base branch from widget-ui-9 to develop October 23, 2023 11:11
… widget-ui-10

# Conflicts:
#	apps/cowswap-frontend/src/modules/wallet/pure/Web3StatusInner/index.tsx
#	apps/widget-configurator/src/app/app.tsx
#	apps/widget-configurator/src/app/configurator/index.tsx
#	apps/widget-configurator/src/main.tsx
#	libs/ui/src/pure/Row/index.tsx
@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
@fairlighteth
@shoom3301
@michel
Michel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@shoom3301 shoom3301 merged commit e2df98d into develop Oct 25, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@alfetopito alfetopito deleted the widget-ui-10 branch October 25, 2023 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants