feat(widget): google analytics dimension for injected widget app id #3272
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
changed the title
| @@ -93,6 +96,15 @@ export function useAnalyticsReporter() { | |||
| googleAnalytics.setDimension(Dimensions.market, marketDimension) | |||
| }, [marketDimension]) | |||
|
|
|||
| useEffect(() => { | |||
| // Custom dimension 6 - injected widget app id | |||
There was a problem hiding this comment.
Do we need to add it also in Google Analytics side?
There was a problem hiding this comment.
I thought it was your idea at the last meeting 😄
| const APP_CODE = process.env.REACT_APP_APP_CODE | ||
|
|
||
| export function useAppData(): AppDataInfo | null { | ||
| return useAtomValue(appDataInfoAtom) | ||
| } | ||
|
|
||
| export function useAppCode(): string | null { | ||
| const injectedWidgetMetaData = useAtomValue(injectedWidgetMetaDataAtom) | ||
| const injectedWidgetMetaData = useInjectedWidgetMetaData() |
There was a problem hiding this comment.
nitpick
not comming from this PR, but in principle not sure we want to make all modules aware there's an injected mode and instead is the client of this module informing one time whats the appKey
This way, in injected mode, it will inject the appData, otherwise it will get it from the env.
Otherwise, we leak a lot of CoW Swap logic here. Imagine we want to promote this module to a lib and use for other projects, then the injected mode would be bothering us.
There was a problem hiding this comment.
Yeah, I also feel it's not the best solution. However, I don't see any better ways
Summary
appIdtoappDataas an app codeappIdto google analytics dimension