Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix issue with sounds #3279

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Oct 26, 2023

Summary

Continuation on #3278

Fixes an issue that was making the spooky sounds not to sound (case where you have in your local storage the light theme setting)

Credits to @alfetopito to find the issue!

Before this PR you could reproduce by adding the following value to the local storage key redux_localstorage_simple_user:

{"selectedWalletBackfilled":true,"matchesDarkMode":true,"userDarkMode":false,"userExpertMode":false,"recipientToggleVisible":false,"userLocale":"en-US","userClientSideRouter":false,"userHideClosedPositions":false,"userSlippageTolerance":"auto","userSlippageToleranceHasBeenMigratedToAuto":true,"userDeadline":1800,"tokens":{"1":{"0x6B175474E89094C44Da98b954EedeAC495271d0F":{"chainId":1,"address":"0x6B175474E89094C44Da98b954EedeAC495271d0F","decimals":18,"symbol":"DAI","name":"Dai Stablecoin"},"0xDEf1CA1fb7FBcDC777520aa7f396b4E015F497aB":{"chainId":1,"address":"0xDEf1CA1fb7FBcDC777520aa7f396b4E015F497aB","decimals":18,"symbol":"COW","name":"CoW Protocol Token"},"0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2":{"chainId":1,"address":"0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2","decimals":18,"symbol":"WETH","name":"Wrapped Ether"},"0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48":{"chainId":1,"address":"0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48","decimals":6,"symbol":"USDC","name":"USD Coin"},"0xC0c293ce456fF0ED870ADd98a0828Dd4d2903DBF":{"chainId":1,"address":"0xC0c293ce456fF0ED870ADd98a0828Dd4d2903DBF","decimals":18,"symbol":"AURA","name":"Aura"},"0xCdCFc0f66c522Fd086A1b725ea3c0Eeb9F9e8814":{"chainId":1,"address":"0xCdCFc0f66c522Fd086A1b725ea3c0Eeb9F9e8814","decimals":18,"symbol":"AURA","name":"Aurora DAO"},"0x543Ff227F64Aa17eA132Bf9886cAb5DB55DCAddf":{"chainId":1,"address":"0x543Ff227F64Aa17eA132Bf9886cAb5DB55DCAddf","decimals":18,"symbol":"GEN","name":"DAOstack"},"0x89d24A6b4CcB1B6fAA2625fE562bDD9a23260359":{"chainId":1,"address":"0x89d24A6b4CcB1B6fAA2625fE562bDD9a23260359","decimals":18,"symbol":"DAI","name":"Dai Stablecoin v1.0"}},"5":{"0xD87Ba7A50B2E7E660f678A895E4B72E7CB4CCd9C":{"chainId":5,"address":"0xD87Ba7A50B2E7E660f678A895E4B72E7CB4CCd9C","decimals":6,"symbol":"USDC","name":"USD Coin"},"0x3430d04E42a722c5Ae52C5Bffbf1F230C2677600":{"chainId":5,"address":"0x3430d04E42a722c5Ae52C5Bffbf1F230C2677600","decimals":18,"symbol":"COW","name":"CoW Protocol Token"},"0x91056D4A53E1faa1A84306D4deAEc71085394bC8":{"chainId":5,"address":"0x91056D4A53E1faa1A84306D4deAEc71085394bC8","decimals":18,"symbol":"COW","name":"CoW Protocol Token"},"0x02ABBDbAaa7b1BB64B5c878f7ac17f8DDa169532":{"chainId":5,"address":"0x02ABBDbAaa7b1BB64B5c878f7ac17f8DDa169532","decimals":18,"symbol":"GNO","name":"Gnosis Token"},"0xdc31Ee1784292379Fbb2964b3B9C4124D8F89C60":{"chainId":5,"address":"0xdc31Ee1784292379Fbb2964b3B9C4124D8F89C60","decimals":18,"symbol":"DAI","name":"Dai"},"0x7b77F953e703E80CD97F6911385c0b1ceabC96Bc":{"chainId":5,"address":"0x7b77F953e703E80CD97F6911385c0b1ceabC96Bc","decimals":6,"symbol":"USDT","name":"Tether USD"}},"100":{"0xDF613aF6B44a31299E48131e9347F034347E2F00":{"chainId":100,"address":"0xDF613aF6B44a31299E48131e9347F034347E2F00","decimals":18,"symbol":"AAVE","name":"Aave Token on xDai"},"0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d":{"chainId":100,"address":"0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d","decimals":18,"symbol":"WXDAI","name":"Wrapped XDAI"},"0x177127622c4A00F3d409B75571e12cB3c8973d3c":{"chainId":100,"address":"0x177127622c4A00F3d409B75571e12cB3c8973d3c","decimals":18,"symbol":"COW","name":"CoW Protocol Token from Mainnet"},"0xDDAfbb505ad214D7b80b1f830fcCc89B60fb7A83":{"chainId":100,"address":"0xDDAfbb505ad214D7b80b1f830fcCc89B60fb7A83","decimals":6,"symbol":"USDC","name":"USD//C on xDai"},"0x1e2C4fb7eDE391d116E6B41cD0608260e8801D59":{"chainId":100,"address":"0x1e2C4fb7eDE391d116E6B41cD0608260e8801D59","decimals":18,"symbol":"bCSPX","name":"Backed CSPX Core S&P 500"},"0xCA30c93B02514f86d5C86a6e375E3A330B435Fb5":{"chainId":100,"address":"0xCA30c93B02514f86d5C86a6e375E3A330B435Fb5","decimals":18,"symbol":"bIB01","name":"Backed IB01 $ Treasury Bond 0-1yr"},"0x52d134c6DB5889FaD3542A09eAf7Aa90C0fdf9E4":{"chainId":100,"address":"0x52d134c6DB5889FaD3542A09eAf7Aa90C0fdf9E4","decimals":18,"symbol":"bIBTA","name":"Backed IBTA $ Treasury Bond 1-3yr"},"0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1":{"chainId":100,"address":"0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1","decimals":18,"symbol":"WETH","name":"Wrapped Ether on xDai"},"0xcB444e90D8198415266c6a2724b7900fb12FC56E":{"chainId":100,"address":"0xcB444e90D8198415266c6a2724b7900fb12FC56E","decimals":18,"symbol":"EURe","name":"Monerium EUR emoney"}}},"pairs":{},"timestamp":1698341013713,"URLWarningVisible":true,"showDonationLink":true,"favouriteTokens":{"1":{"0x6B175474E89094C44Da98b954EedeAC495271d0F":{"chainId":1,"address":"0x6B175474E89094C44Da98b954EedeAC495271d0F","decimals":18,"symbol":"DAI","name":"Dai Stablecoin"},"0xDEf1CA1fb7FBcDC777520aa7f396b4E015F497aB":{"chainId":1,"address":"0xDEf1CA1fb7FBcDC777520aa7f396b4E015F497aB","decimals":18,"symbol":"COW","name":"CoW Protocol Token"},"0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48":{"chainId":1,"address":"0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48","decimals":6,"symbol":"USDC","name":"USD//C"},"0xdAC17F958D2ee523a2206206994597C13D831ec7":{"chainId":1,"address":"0xdAC17F958D2ee523a2206206994597C13D831ec7","decimals":6,"symbol":"USDT","name":"Tether USD"},"0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599":{"chainId":1,"address":"0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599","decimals":8,"symbol":"WBTC","name":"Wrapped BTC"},"0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2":{"chainId":1,"address":"0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2","decimals":18,"symbol":"WETH","name":"Wrapped Ether"}},"5":{"0xB4FBF271143F4FBf7B91A5ded31805e42b2208d6":{"chainId":5,"address":"0xB4FBF271143F4FBf7B91A5ded31805e42b2208d6","decimals":18,"symbol":"WETH","name":"Wrapped Görli Ether"},"0x91056D4A53E1faa1A84306D4deAEc71085394bC8":{"chainId":5,"address":"0x91056D4A53E1faa1A84306D4deAEc71085394bC8","decimals":18,"symbol":"COW","name":"CoW Protocol Token"},"0xdc31Ee1784292379Fbb2964b3B9C4124D8F89C60":{"chainId":5,"address":"0xdc31Ee1784292379Fbb2964b3B9C4124D8F89C60","decimals":18,"symbol":"DAI","name":"DAI"},"0xD87Ba7A50B2E7E660f678A895E4B72E7CB4CCd9C":{"chainId":5,"address":"0xD87Ba7A50B2E7E660f678A895E4B72E7CB4CCd9C","decimals":6,"symbol":"USDC","name":"USD Coin"}},"100":{"0xDDAfbb505ad214D7b80b1f830fcCc89B60fb7A83":{"chainId":100,"address":"0xDDAfbb505ad214D7b80b1f830fcCc89B60fb7A83","decimals":6,"symbol":"USDC","name":"USD Coin"},"0x8e5bBbb09Ed1ebdE8674Cda39A0c169401db4252":{"chainId":100,"address":"0x8e5bBbb09Ed1ebdE8674Cda39A0c169401db4252","decimals":8,"symbol":"WBTC","name":"Wrapped BTC"},"0x177127622c4A00F3d409B75571e12cB3c8973d3c":{"chainId":100,"address":"0x177127622c4A00F3d409B75571e12cB3c8973d3c","decimals":18,"symbol":"COW","name":"CoW Protocol Token"},"0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1":{"chainId":100,"address":"0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1","decimals":18,"symbol":"WETH","name":"Wrapped Ether on Gnosis Chain"},"0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d":{"chainId":100,"address":"0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d","decimals":18,"symbol":"WXDAI","name":"Wrapped XDAI"}}},"lastUpdateVersionTimestamp":1698341012716,"selectedWallet":"INJECTED"}

Test

Try to set the storage provided above and verify that now the sounds are back

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview Oct 26, 2023 5:30pm

🌃 Cosmos ↗︎

@anxolin
Copy link
Contributor Author

anxolin commented Oct 26, 2023

Merging optimistically to close the release!

@anxolin anxolin changed the base branch from develop to hotfix/1.48.9 October 26, 2023 17:33
@anxolin anxolin merged commit f7c1135 into hotfix/1.48.9 Oct 26, 2023
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@alfetopito alfetopito deleted the fix-sounds-for-light-theme branch October 27, 2023 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant