fix(twap): fix infinite loop in orders hook #3348
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // Fetch PROD orders only when current env is not prod | ||
| // We need them for TWAP, because WatchTower creates orders only on Prod | ||
| export function useSWRProdOrders(): EnrichedOrder[] { | ||
| const { chainId } = useWalletInfo() | ||
| const requestParams = useSWROrdersRequest() | ||
| const apiOrders = useApiOrders() | ||
|
|
||
| const { data: loadedProdOrders = [] } = useSWR<EnrichedOrder[]>( | ||
| const { data: loadedProdOrders = EMPTY_ORDERS } = useSWR<EnrichedOrder[]>( |
There was a problem hiding this comment.
ok, great, we return always the same empty object, so in case there's no orders, the depending components and hooks won't re-render cause is the same identity (i assume the issue was the fact [] !== [])
My only concern is that this might be covering up the real place where the issue originated
Isn't the issue that we are re-rendering somewhere everything even if the loader orders doesn't change?
There was a problem hiding this comment.
i assume the issue was the fact [] !== []
Exactly
Isn't the issue that we are re-rendering somewhere everything even if the loader orders doesn't change?
I've revisited all hook deps and found problem only here
Summary
While testing I noticed that my M2 Max processor sometimes freezes.
By stopping the main thread periodically I noticed that I almost always get into
CreatedInOrderBookOrdersUpdater.After adding a
console.loghere I saw that it gets tons of recalculations forpartOrdersFromProd.After some bisection on
useAsyncMemodeps I got intouseSWRProdOrdersand here I found the cause of the problem.So, the main problem in the fact that we always return a new array and it makes
useAsyncMemo()recalculate everything many times.tttt.mov
To Test
console.loglike:Before the fix I got tons of console logs. After only few