Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change from node v16 to v18 #3350

Merged
merged 2 commits into from
Nov 7, 2023
Merged

feat: change from node v16 to v18 #3350

merged 2 commits into from
Nov 7, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Nov 7, 2023 •
edited
Loading

Summary

Just a quick test, since locally worked and v16 will be deprecated soon.

We want to get rid of this warning, and build using a more modern Node version:

image

It looks like it worked, the 3 apps were build correctly! 🎉

Actually, the widget and cosmos were already migrated.

Test

Test this doesn't break anything

nvm install
nvm use
yarn 

yarn build

yarn start

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 1:36pm
swap-dev ✅ Ready (Inspect) Visit Preview Nov 7, 2023 1:36pm
widget-configurator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 1:36pm

@anxolin anxolin marked this pull request as ready for review November 7, 2023 13:29
@anxolin anxolin requested a review from a team November 7, 2023 13:30
@anxolin anxolin changed the title Test node18 feat: change from node v16 to v18 Nov 7, 2023
alfetopito
alfetopito reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok.
There are a bunch of unrelated changes and one change that doesn't seem to belong there

.github/workflows/vercel.yml Outdated Show resolved Hide resolved
@anxolin anxolin changed the base branch from develop to release/1.49.0 November 7, 2023 13:33
@anxolin
Copy link
Contributor Author

anxolin commented Nov 7, 2023

Looks mostly ok.
There are a bunch of unrelated changes and one change that doesn't seem to belong there

the base branch was wrong. I just changed it now

@anxolin anxolin merged commit edc7de3 into release/1.49.0 Nov 7, 2023
9 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@alfetopito alfetopito deleted the test-node18 branch November 8, 2023 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anxolin @alfetopito @shoom3301