Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile: Make elements responsive: Waterfall PR[7] #384

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Profile: Make elements responsive: Waterfall PR[7] #384

merged 2 commits into from
Apr 6, 2022

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Apr 6, 2022 •
edited
Loading

Summary

  • Makes the elements responsive

Screen Shot 2022-04-06 at 12 35 44

Screen Shot 2022-04-06 at 12 36 00

@fairlighteth fairlighteth requested review from a team April 6, 2022 11:26
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

CLA Assistant Lite:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger the CLA Action by commenting recheckcla in this Pull Request

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Apr 6, 2022

Hey @fairlighteth , nice changes!

However, now the 'Copy' button is shifted in a tablet/mobile view
image

Could you please fix it?

@fairlighteth
Copy link
Contributor Author

@elena-zh Fixed now and also added copy contract for vCOW

elena-zh
elena-zh approved these changes Apr 6, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fairlighteth , LGTM now!

@fairlighteth fairlighteth merged commit c2dcb52 into profile-actions-6 Apr 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
anxolin
anxolin reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so much space between the links? different spacings between the 2 cars
image

@fairlighteth
Copy link
Contributor Author

@anxolin This is mainly for mobile/touch devices where I usually try to leave a so called 'fat finger' margin between items :)

I see the governance card doesn't have equal margin, so something I should optimize at some point.

W3stside
W3stside reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@fairlighteth fairlighteth deleted the profile-actions-7 branch July 4, 2024 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@W3stside W3stside W3stside left review comments

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairlighteth @elena-zh @anxolin @W3stside