Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CLA #391

Merged
merged 3 commits into from
Apr 6, 2022
Merged

update CLA #391

merged 3 commits into from
Apr 6, 2022

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Apr 6, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

nlordell
nlordell approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion would be to link to the CLA repo directly so that its using the "main" version from there.

@nlordell
Copy link
Contributor

nlordell commented Apr 6, 2022 •
edited
Loading

Specifically you could change this line to point to the CLA document in the CLA repo:

cowswap/.github/workflows/cla.yml

Line 22 in d65673d

path-to-cla-document: 'https://github.com/gnosis/cowswap/blob/develop/docs/GNOSIS_CLA.md'

Actually, I just noticed the path needs to be updated. You can probably just change it to:

          path-to-cla-document: 'https://github.com/cowprotocol/cla/blob/main/Cow%20Services%20CLA.md'

And then remove the CLA from this repo altogether.

@W3stside W3stside merged commit b4cbc80 into develop Apr 6, 2022
@W3stside W3stside deleted the update-CLA branch April 6, 2022 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
@anxolin
Copy link
Contributor

anxolin commented Apr 7, 2022 •
edited
Loading

Thanks @W3stside 🙏

would u mind do the same in all repos?
I could use some help to complete migrations https://docs.google.com/document/d/15_iemg8ToI_PEh_w5yvLzzWEFSb49JpI49YeOjewJ8s/edit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@fairlighteth fairlighteth fairlighteth approved these changes

@anxolin anxolin Awaiting requested review from anxolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@W3stside @nlordell @anxolin @fairlighteth