Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear url params on the network change #397

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Apr 7, 2022

Summary

Fixes #386

  • fixes the issue mentioned in the ticket by removing the url query params on the network change

@nenadV91 nenadV91 requested review from a team April 7, 2022 12:42
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Apr 7, 2022

Hey @nenadV91 , great changes!

The URL is changed not on network change request, however, the Swap form still shows 'Select a token' in both fields: https://watch.screencastify.com/v/wNS4MyYBx3LYxwmyremx

Could we clear out the form to the default state? (WETH in 'From' field, 'Select a token'
in the To' field)?

Copy link
Contributor

@fairlighteth fairlighteth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nenadV91 tested your last commit and works as expected:

  • Go to /profile/
  • BUY COW
  • Goes to swap with parameters in the URL
  • Switch any network and URL is cleared

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nenadV91 nenadV91 changed the base branch from release/1.13 to develop April 8, 2022 09:37
@nenadV91 nenadV91 merged commit 736db8d into develop Apr 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
@nenadV91 nenadV91 deleted the 386/clear-url-params branch June 14, 2022 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL parameters aren't cleared out when I change a network
3 participants