Fix unhandled exception on updaters #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
alfetopito
commented
Apr 22, 2022
| console.debug('[UnfillableOrdersUpdater::updateUnfillable] No price quote for', order.id.slice(0, 8)) | ||
| } | ||
| }) | ||
| .catch((e) => { |
There was a problem hiding this comment.
Everything else is a formatting change, I've only added the catch block in this file
|
W3stside
reviewed
Apr 26, 2022
W3stside
reviewed
Apr 26, 2022
W3stside
approved these changes
Apr 26, 2022
alfetopito
force-pushed
the
fix-unhandled-exception-on-updaters
branch
from
559dfa1
to
74733fa
Compare
alfetopito
added
the
Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assorted fix on two unhandled exceptions that caused the app to crash locally.
On prod they are not an issue since they are swallowed and logged as errors.
To Test
Can't really tell how to force them. It happened while developing locally.
It seems I was having connection issues at the time and it just caused the app to crash.