Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locked gno claim 2 fixes #453

Merged
merged 8 commits into from
Apr 26, 2022
Merged

Locked gno claim 2 fixes #453

merged 8 commits into from
Apr 26, 2022

Conversation

jfschwarz
Copy link
Contributor

Addressing most of the change requests from reviewers

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@jfschwarz jfschwarz mentioned this pull request Apr 26, 2022
Merged
nenadV91
nenadV91 approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@nenadV91 nenadV91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , apart from the deploy job failing 👍

@nenadV91 nenadV91 merged commit d1d77b7 into cowprotocol:locked-gno-claim-2 Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nenadV91 nenadV91 nenadV91 approved these changes

@alfetopito alfetopito Awaiting requested review from alfetopito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfschwarz @nenadV91