Add cow from locked GNO to combined balance #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
|
Hey @nenadV91 , great changes! I was about to approve the changes, but I noticed, that the balance and discount info are not zero out when I disconnect a wallet. See the video: https://watch.screencastify.com/v/ry4dmmQjfGu75X9Kvnzq The issue is reproducible in this PR only, as it works fine in the current Prod. |
|
I also noticed, that the discount amount/COW balance are changing several times when the data is loading. |
|
@elena-zh Good catch and suggestion. I've added both. |
elena-zh
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #409
As mentioned in the ticket this will add cow from locked GNO to the combined balance that will be shown in the header button but also included in the discount calculation.