Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

352/network dropdown #459

Merged
merged 5 commits into from
Apr 27, 2022
Merged

352/network dropdown #459

merged 5 commits into from
Apr 27, 2022

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Apr 26, 2022 •
edited
Loading

Summary

Closes #352

  • Hides NetworkSelector on unsupported network
  • shows message toast that network is unsupoprted and what to do
  • changes message in modal in wallet
  • adds better customising props for toasts in future

image

To Test

  1. open app in wrong network in metamask
  2. connect if need be
  3. see message
  4. change to supported chain
  5. message disappears
  6. switch to unsupported chain
  7. see message
  8. open wallet modal
  9. see fixed message

@W3stside W3stside requested review from a team April 26, 2022 16:51
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

anxolin
anxolin reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, although i don't think we should hide the selector as I mentioned in #352 (comment)

Why is better to hide? Functionally i see the user can select any network if they are in the wrong network (same as if they are disconnected)

@W3stside
Copy link
Contributor Author

Nice, although i don't think we should hide the selector as I mentioned in #352 (comment)

Why is better to hide? Functionally i see the user can select any network if they are in the wrong network (same as if they are disconnected)

it's what we discussed
but i can revert it then

@W3stside W3stside requested review from a team April 27, 2022 10:06
elena-zh
elena-zh approved these changes Apr 27, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
But still I'd make the yellow color a bit more brighter in the light theme
image

@W3stside W3stside merged commit 2d174a2 into develop Apr 27, 2022
@W3stside W3stside deleted the 352/network-dropdown branch April 27, 2022 10:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@alfetopito alfetopito alfetopito approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2440/uni merge: remove 'in the dropdown menu' from the Wrong Network message
4 participants
@W3stside @alfetopito @anxolin @elena-zh