Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hooks-store): style hook store #4905

Merged
merged 22 commits into from
Sep 23, 2024
Merged

feat(hooks-store): style hook store #4905

merged 22 commits into from
Sep 23, 2024

Conversation

fairlighteth
Copy link
Contributor

Summary

Screenshot 2024-09-17 at 14 29 56 Screenshot 2024-09-17 at 14 29 46 Screenshot 2024-09-17 at 14 29 35 Screenshot 2024-09-17 at 14 29 29
Screen.Recording.2024-09-17.at.14.28.23.mov

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Sep 23, 2024 10:25am
cowfi ✅ Ready (Inspect) Visit Preview Sep 23, 2024 10:25am
explorer-dev ✅ Ready (Inspect) Visit Preview Sep 23, 2024 10:25am
swap-dev ✅ Ready (Inspect) Visit Preview Sep 23, 2024 10:25am
widget-configurator ✅ Ready (Inspect) Visit Preview Sep 23, 2024 10:25am

@fairlighteth fairlighteth requested review from a team September 17, 2024 14:10
@fairlighteth
Copy link
Contributor Author

Pushed some mobile/responsive updates

@elena-zh
Copy link

Hey @fairlighteth , thank you for addressing this!
I have some trivial issues to report:

  1. It would be great to remove 'Gnosis' from the Safe wallet name
    Gnosis
  2. It would be great to write words in the validation message in the same manner as labels are written (e.g. start with capitals, add spaces between words):
    lit
  3. Arrows in the Gas limit field do not look good in the dark mode (at least, in Win11):
    arrows in the dark mode (win11)

@shoom3301
Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…
e9aa316 
… hooks-styling-2

# Conflicts:
#	apps/cowswap-frontend/src/modules/hooksStore/dapps/BuildHookApp/index.tsx
@shoom3301
chore: merge develop
2795c31
@shoom3301
Copy link
Collaborator

@elena-zh @fairlighteth I just pulled changes from develop in this branch and addressed the issues from @elena-zh .
@fairlighteth please, don't forget about commit message convention before merging this PR

@alfetopito alfetopito changed the title Hooks styling 2 feat(hooks-store): style hook store Sep 23, 2024
elena-zh
elena-zh approved these changes Sep 23, 2024
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but it would be great if fields names on validation messages corresponded to the fields names
image

image

@shoom3301 @alfetopito
Update hook.tsx
51338f1 
Co-authored-by: Leandro <[email protected]>
@shoom3301 shoom3301 merged commit 9fca0d9 into develop Sep 23, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the hooks-styling-2 branch September 23, 2024 10:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
Hooks store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairlighteth @elena-zh @shoom3301 @alfetopito