Fix cypress #493
Merged
Fix cypress #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
anxolin
approved these changes
Apr 29, 2022
| // When `.clear() doesn't work, brute force it with the input below. | ||
| // From https://stackoverflow.com/a/65918033/1272513 | ||
| .type('{selectall}{backspace}{selectall}{backspace}') | ||
| .type('0.0', { delay: 400 }) |
There was a problem hiding this comment.
do we still need the delay?
There was a problem hiding this comment.
Not sure, but I did not test without it
W3stside
approved these changes
Apr 29, 2022
| }) | ||
|
|
||
| it('can swap Native for DAI', () => { | ||
| cy.get('#swap-currency-output .open-currency-select-button').click() | ||
| cy.get('.token-item-0xc7AD46e0b8a400Bb3C915120d284AafbA8fc4735').should('be.visible') | ||
| cy.get('.token-item-0xc7AD46e0b8a400Bb3C915120d284AafbA8fc4735').click({ force: true }) | ||
| cy.get('#swap-currency-input .token-amount-input').should('be.visible') | ||
| cy.get('#swap-currency-input .token-amount-input').type('0.001', { delay: 400, force: true }) | ||
| cy.get('#swap-currency-input .token-amount-input').clear().type('0.5', { delay: 400, force: true }) |
There was a problem hiding this comment.
So we not need the brute force clear here as well?
There was a problem hiding this comment.
For some reason, not everywhere is needed.
Did not try hard enough to see whether that would break without it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing integration tests broken on #457
Note: One fix I did that isn't code related was approving WETH for the integ test account
0x68D25464371F3a97691c52e40d4C1306aF0B7629.To Test