Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slippage): small order slippage v2 #4934

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

feat(slippage): small order slippage v2 #4934

wants to merge 21 commits into from
+412 −128

Commits on Oct 4, 2024

  1. fix: ignore quote metadata when deciding to to trigger a new quote

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    70b0863 View commit details
    Browse the repository at this point in the history

  2. fix: memoize useGetQuoteAndStatus response

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c599d79 View commit details
    Browse the repository at this point in the history

  3. feat: use smart slippage based on trade size in relation to fee

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4c01dd0 View commit details
    Browse the repository at this point in the history

  4. feat: show loading indicator on suggested slippage when trade is loading

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9e8d580 View commit details
    Browse the repository at this point in the history

  5. chore: fix cosmos build

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6e7787e View commit details
    Browse the repository at this point in the history

  6. chore: fix lint

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ecb55ee View commit details
    Browse the repository at this point in the history

  7. feat: use smart slippage based on fee amount %

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2796c1f View commit details
    Browse the repository at this point in the history

  8. feat: use fee multiplier factor from launch darkly

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d77ec8b View commit details
    Browse the repository at this point in the history

  9. refactor: exit earlier if LD multiplier is falsy

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7d99f38 View commit details
    Browse the repository at this point in the history

  10. fix: return undefined and avoid setting smart slippage when both are … 

    …missing
    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c721402 View commit details
    Browse the repository at this point in the history

  11. feat: cap slippage at 50%

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4a44653 View commit details
    Browse the repository at this point in the history

  12. refactor: split FeesUpdater

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d540b5b View commit details
    Browse the repository at this point in the history

  13. refactor: use useSafeMemoObject instead of useMemo

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0be6007 View commit details
    Browse the repository at this point in the history

  14. refactor: avoid repeating the same code

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    44cad9b View commit details
    Browse the repository at this point in the history

  15. refactor: split SmartSlippageUpdater

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    26280dd View commit details
    Browse the repository at this point in the history

  16. refactor: extract calculateBpsFromFeeMultiplier and added unittests

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c964b9f View commit details
    Browse the repository at this point in the history

  17. feat: cap the sum of calculated slippages at 50%

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    231ac6e View commit details
    Browse the repository at this point in the history

  18. refactor: rename variable to calculateBpsFromFeeMultiplier

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f57253c View commit details
    Browse the repository at this point in the history

  19. fix: fix before and after as they don't mean the same thing for buy a… 

    …nd sell orders
    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ccd5c19 View commit details
    Browse the repository at this point in the history

  20. fix: reset smart slippage when both are disabled

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1fbd9dd View commit details
    Browse the repository at this point in the history

  21. fix: don't update smart slippage if trade review modal is open

    @alfetopito
    alfetopito committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b6a4208 View commit details
    Browse the repository at this point in the history