Fix unhandled exception when checking whether address is SC #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
W3stside
approved these changes
May 5, 2022
|
@alfetopito , #514 is not reproducible here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"You see something, you do something" kind of fix
While testing locally the app broke because this check was unhandled
Not a through investigation of what caused it, just handling it to prevent the app from crashing
Not a problem on prod where it'll be swallowed and logged as an error
To Test
Only visible locally, no way to reproduce in the PR
Besides, no clear path for reproduction either, happened while switching to unsupported networks back and forth trying to reproduce #514
Maybe related, but unsure