Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back popup notifications :) #525

Merged
merged 1 commit into from
May 5, 2022

Conversation

alfetopito
Copy link
Collaborator

Summary

Closes #516

Notifications were removed by accident due to a bad merge on 7c016a6

To Test

  1. Place an order
  • You should see the notification pop up

@alfetopito alfetopito self-assigned this May 5, 2022
@alfetopito alfetopito requested review from a team May 5, 2022 10:34
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alfetopito alfetopito merged commit f64eb59 into release/1.14 May 5, 2022
@alfetopito alfetopito deleted the 516/fix-notifications-not-shown branch May 5, 2022 12:01
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants