[Batch Viewer] Add a Reset button + autoscale graph area #100
Conversation
alongoni
added
app:Explorer
alongoni
changed the title
alongoni
changed the title
|
Pull Request Test Coverage Report for Build 2437139669Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
alongoni
changed the title
|
|
||
| setElements(getNodes(txSettlement, networkId, heightSize)) | ||
| }, [heightSize, error, isLoading, networkId, txSettlement]) | ||
| setResetZoom(null) | ||
| }, [error, isLoading, txSettlement, networkId, heightSize, resetZoom]) |
| ref.layout(getLayout()).run() | ||
| ref.fit() | ||
| } | ||
| ref.on('resize', () => { |
There was a problem hiding this comment.
@henrypalacios is this subscription properly cleaned when the chart is unmounted?
There was a problem hiding this comment.
The listeners seem to be removed when destroy the component, (I couldn't catch it from the documentation).
But with a thorough review of the Cy.Core object I got:
-
I found that there were memory leaks for the events at interaction time. (I have corrected it)
-
An untyped method that remove all the listener that we can use it to make sure that it is going to clean everything when unmounted.
Summary
Closes #48 and #44
To Test