Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setup Sentry only when Desktop is onboarded #2314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taratatach
Copy link
Member

@taratatach taratatach commented Jul 26, 2023

We need a valid Desktop config to setup our Sentry integration as we
use the Cozy URL to determine the domain, the instance and the
environment of the Cozy to tag our events.

Since we want to receive events as soon as possible, we setup Sentry
very early and, when Desktop is not onboarded already, we get an error
since we don't have the required data.
This is not a big deal but the error is printed in the console.

We'll now make sure we have a valid configuration before trying to
setup the integration and we'll also make sure to set it up after the
onboarding is done to receive events without the need for an app
restart.

Please make sure the following boxes are checked:

  • PR is not too big
  • it improves UX & DX in some way
  • it includes unit tests matching the implementation changes
  • it includes scenarios matching a new behaviour or has been manually tested
  • it includes relevant documentation

@taratatach taratatach self-assigned this Jul 26, 2023
  We need a valid Desktop config to setup our Sentry integration as we
  use the Cozy URL to determine the domain, the instance and the
  environment of the Cozy to tag our events.

  Since we want to receive events as soon as possible, we setup Sentry
  very early and, when Desktop is not onboarded already, we get an error
  since we don't have the required data.
  This is not a big deal but the error is printed in the console.

  We'll now make sure we have a valid configuration before trying to
  setup the integration and we'll also make sure to set it up after the
  onboarding is done to receive events without the need for an app
  restart.
@taratatach taratatach force-pushed the fix/setup-sentry-only-if-onboarded branch from 5c6b5b8 to 294ed6d Compare July 26, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant