feat: Improve generateFiles command to create qualified files #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
force-pushed
the
feat/ver-331
branch
3 times, most recently
from
0faff36
to
25188f7
Compare
Merkur39
changed the title
Merkur39
changed the title
Merkur39
force-pushed
the
feat/ver-331
branch
5 times, most recently
from
ff01d65
to
ebe283f
Compare
zatteo
reviewed
Mar 11, 2024
zatteo
reviewed
Mar 11, 2024
|
Thank you a lot! |
zatteo
approved these changes
Mar 11, 2024
BREACKING CHANGE: The `path` argument is replaced by `dirId`, and goes to second position. Example to generate 2 files at the root of your Drive: Before ``` ACH generateFiles <folderPath> <nbOfFile> ``` Now ``` ACH generateFiles <nbOfFile> <folderId> ```
|
🎉 This PR is included in version 1.53.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En l'état, les changements apportés par cette PR conserve le fonctionnement de la commande
generateFilesmais vont aussi lui permettre de générer des fichiers qualifiés (avec les qualifications existantes sur cozy-client)Info importante, certaines apps comme MesPapiers fetch les fichiers qualifiés mais qui doivent aussi avoir la prop
cozyMetadata.createdByApp.La création via ACH retourne bien des fichiers qualifiés mais sans cette prop, pour l'avoir il suffit de générer un token d'app/connecteur (le token de l'app où vous souhaitez voir les fichiers semble bien) et de le passer à ACH via l'option
-t.