feat: Use ensureKonnectorFolder from cozy-client #964
Conversation
doubleface
force-pushed
the
feat/cozyClientEnsureKonnectorFolder
branch
from
571f8e6
to
8855c14
Compare
src/libs/Launcher.js
Outdated
| konnector, | ||
| account | ||
| const folder = await models.konnectorFolder.ensureKonnectorFolder(client, { | ||
| konnector: { ...konnector, _id: konnector._id }, |
There was a problem hiding this comment.
_id attribute is missing in konnector object, which causes the reference to the konnector in the destination folder to be null
I think there is something to fix in harvest when the launcher context is sent
There was a problem hiding this comment.
I don't understand:
You do:
konnector: { ...konnector, _id: konnector._id }
and you say : "_id attribute is missing in konnector object,". But you do: _id: konnector._id so _id is present in the konnector object. If this is not the case, you'll have _id: undefined is it really wanted?
There was a problem hiding this comment.
Sorry, I miss typed. The right code is konnector: { ...konnector, _id: konnector.id } and I fixed it now.
src/libs/Launcher.js
Outdated
| @@ -289,6 +289,27 @@ export default class Launcher { | |||
| trigger = triggerResponse.data | |||
| result.createdTrigger = trigger | |||
| log.debug(`ensureAccountAndTriggerAndJob: created trigger`, trigger) | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
can you add a comment to explain why you need to ignore 🙏 (if you can't fix it right now)
There was a problem hiding this comment.
Done, the message attribute of IOCozyTrigger is kind of a free object. Its content depends on the kind of trigger. But all the konnector trigger (client or node) which have a destination folder will have the .message.folder_to_save attribute.
There was a problem hiding this comment.
So let's update the IOCozyTrigger type on Cozy-client 🙏
There was a problem hiding this comment.
Here it is cozy/cozy-client#1398
doubleface
force-pushed
the
feat/cozyClientEnsureKonnectorFolder
branch
3 times, most recently
from
3db6ae7
to
b096cfb
Compare
|
@Crash-- Should be updated now |
And also update the destination folder id saved in the trigger when needed. Upgrade cozy-client to 41.4.1 to be able to update the trigger and to have ensureKonnectorFolder function.
doubleface
force-pushed
the
feat/cozyClientEnsureKonnectorFolder
branch
from
b096cfb
to
3051efb
Compare
|
Upgraded cozy-client with the updated triggers types and removed some @ts-ignore |
And also update the destination folder id saved in the trigger when
needed.
Upgrade cozy-client to 41.4.1 to be able to update the trigger and to
have ensureKonnectorFolder function.
Checklist
Before merging this PR, the following things must have been done: