Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log the finally installed clisk konnector version #969

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

doubleface
Copy link
Contributor

For a better debug experience

Please explain what this PR does here.

Checklist

Before merging this PR, the following things must have been done:

  • Faithful integration of the mockups at all screen sizes
  • Tested on iOS
  • Tested on Android
  • Localized in English and French
  • All changes have test coverage
  • Updated README & CHANGELOG, if necessary

@Crash--
Copy link
Contributor

Crash-- commented Oct 10, 2023

Maybe can we add a log there too: https://github.com/cozy/cozy-flagship-app/blob/master/src/screens/konnectors/LauncherView.js#L139

In order to be sure that we got the right content script (version) ?

@doubleface doubleface force-pushed the feat/logInstalledKonnectorVersion branch 2 times, most recently from e372e8a to c4ce3c0 Compare October 10, 2023 08:22
@doubleface
Copy link
Contributor Author

Maybe can we add a log there too

@Crash-- Done

Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@doubleface doubleface force-pushed the feat/logInstalledKonnectorVersion branch from c4ce3c0 to 8fab288 Compare October 10, 2023 09:12
@doubleface
Copy link
Contributor Author

Fixed LauncherView unit tests

@doubleface doubleface merged commit dee3b54 into master Oct 10, 2023
1 check passed
@doubleface doubleface deleted the feat/logInstalledKonnectorVersion branch October 10, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants