fix: Ensure sourceAccountIdentifier is present in getUserDataFromWebsite return value #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite return value Or else, if the konnector does not return any sourceAccountIdentifier, the account and trigger will be created and the execution will fail when trying to create the desination folder, which makes it harder to link with the missing sourceAccountIdentifier.
Crash--
reviewed
Oct 10, 2023
| throw new Error( | ||
| 'getUserDataFromWebsite did not return any sourceAccountIdentifier. Cannot continue the execution.' | ||
| ) | ||
| } |
There was a problem hiding this comment.
What are we displaying to the user in that case?
There was a problem hiding this comment.
Since this is a technical error, the generic error message is displayed to the user.
There was a problem hiding this comment.
This error is printed / sent to the logs?
There was a problem hiding this comment.
Now, yes, since #965
Crash--
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or else, if the konnector does not return any sourceAccountIdentifier,
the account and trigger will be created and the execution will fail when
trying to create the desination folder, which makes it harder to link
with the missing sourceAccountIdentifier.
Checklist
Before merging this PR, the following things must have been done: