Refactor the initials package in order to be able to accept new implementations
#3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a required work to propose several implementation for the avatar generation
This package is responsible to handling avatars, the initials are only one possible way to implement avatars and for what I have understood a gravatar implementation could be implemented in the future.
nono
approved these changes
Mar 7, 2023
This will allow to propose a new implementation based on SVG
nono
reviewed
Mar 7, 2023
|
Erf, good catch. That was a test because I didn't understand why the files didn't match. I remove |
nono
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preliminary work for solving #3679 .