Feat: Update react-pdf to 5.7.2 #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
requested review from
JF-Cozy,
Merkur39,
Ldoppea and
zatteo
as code owners
BundleMonUnchanged files (2)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
cballevre
force-pushed
the
feat/update-react-pdf-to-5.7.2
branch
2 times, most recently
from
db24a93
to
ca11c18
Compare
JF-Cozy
approved these changes
Apr 17, 2023
| @@ -247,7 +247,7 @@ For performance reasons, it is important to use a web worker when showing PDF fi | |||
| ```diff | |||
| + resolve: { | |||
| + alias: { | |||
| + 'react-pdf$' : 'react-pdf/dist/entry.webpack.js' | |||
| + 'react-pdf$' : 'react-pdf/dist/esm/entry.webpack' | |||
There was a problem hiding this comment.
il y a un souci dans le commit message au niveau du BC je crois, dans le before on devrait avoir react-pdf/dist/entry.webpack.js non ?
There was a problem hiding this comment.
Oh oui tous juste une erreur de copier-coller je corrige ça de suite
This update provides version 2.12.313 of pdfjs-dist. This version resolves rendering issues with some PDFs. BREAKING CHANGE: This update requires the two changes above in your application if you use the `Viewer` to display PDF. You can find more detail in `Viewer` documentation : https://docs.cozy.io/cozy-ui/react/#!/Viewer Before : - react-pdf alias : `react-pdf/dist/entry.webpack.js` - public import for pdf worker : `react-pdf/dist/pdf.worker.entry.js` After : - react-pdf alias : `react-pdf/dist/esm/entry.webpack` - public import for pdf worker : `react-pdf/dist/esm/pdf.worker.entry`
cballevre
force-pushed
the
feat/update-react-pdf-to-5.7.2
branch
from
ca11c18
to
174bd4d
Compare
|
🎉 This PR is included in version 83.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update provides version 2.12.313 of pdfjs-dist. This version resolves rendering issues with some PDFs like the screenshot above. There is two breaking change on the way to import react-pdf into final application. All the detail can be found into the commit message of c0d7441
Development notes :
I tried to upgrade to the latest version of react-pdf which is currently 6.2.2. But I encountered a problem related to this issue: wojtekmaj/react-pdf#1043 from the pdf.js lib. It seems that there is a link with our webpack configuration. I modified the babel configuration to transcompile the pdf.js module without success.