Allows set/set(CACHE) to behave the same as set(X)/option(x) #335
Conversation
By enabling CMP0126 we tell CMake that when constructing a CACHE variable with the same name as a local variable to not unset the local variable. By enabling CMPO126 it makes sure that CPM behavior around `OPTION` is consistent if the option is created with `set(CACHE)` or with `option`.
|
I'm generally in favor of the policy being set, but not of adding NVIDIA to the copyright in CPM.cmake. If we were to add every single contributor, the copyright notice could end up being longer than the actual code. Still, having an external file which lists all contributors is probably not a bad idea |
I have removed that modification while you work out a better way to list contributors. Thank you |
robertmaynard
force-pushed
the
add_cmp0126_to_option
branch
from
fde9034
to
88caa86
Compare
|
Hey, thanks for the PR, setting the policy definitely looks like a good idea! As for the contributors, I'd be interested how other projects handle this. In general, I wouldn't be opposed to adding a contributors file (and referencing it from the licence), where we can give credit to the people / organisations that have helped with the project. |
By enabling CMP0126 we tell CMake that when constructing a CACHE variable
with the same name as a local variable to not unset the local variable.
By enabling CMPO126 it makes sure that CPM behavior around
OPTIONisconsistent if the option is created with
set(CACHE)or withoption.