-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per package CPM_DOWNLOAD controls #336
Add per package CPM_DOWNLOAD controls #336
Conversation
Introduces support for `CPM_<PACKAGE>_DOWNLOAD` variable ( and env ) which allows finer grained control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Interesting this like the variant I thought here #280 (but still didn't take time to implement) |
43411b4
to
b10c7b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of how this can break anything. Looks good to me.
@TheLartians what do you think?
Also, this makes is a good use case for an integration test, I'll try do add one for this over the weekend
Agreed, this looks good! Definitely worth it to add an integration test, so we don't accidentally break it in the future. |
@iboB are you still planning to write some integration tests for this feature? |
Yes. At least a very bare-bones one. I'm a bit short on time, though. I think if we're satisfied with this, we can merge and I can add tests later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks @robertmaynard for the feature!
Introduces support for
CPM_<PACKAGE>_DOWNLOAD
variable ( and env ) which allows finer grained control.A common workflow pattern we have run into is wanting to set
CPM_DOWNLOAD_ALL
to on for a middle package in a CPM dependency chain.This would allow us to state that project A needs to be downloaded but project B or C can be found on disk.