Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CMake 3.14+ documented way to pass the source dir -S. #337

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Use CMake 3.14+ documented way to pass the source dir -S. #337

merged 1 commit into from
Jan 27, 2022

Conversation

robertmaynard
Copy link
Contributor

The -H<src_dir> was never officially documented by CMake

@robertmaynard
Use CMake 3.14+ documented way to pass the source dir -S.
b71add0 
The `-H<src_dir>` was never officially documented by CMake
iboB
iboB approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@iboB iboB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@iboB iboB requested a review from TheLartians January 27, 2022 14:51
TheLartians
TheLartians approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I was using -H in the past before I knew -S existed, but it's definitely time to switch to the official solution.

@TheLartians TheLartians merged commit 11c7ec8 into cpm-cmake:master Jan 27, 2022
@robertmaynard robertmaynard deleted the use_official_source_dir_flag branch January 28, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLartians TheLartians TheLartians approved these changes

@iboB iboB iboB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @iboB @TheLartians