-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added download status, added comparison by hash sum #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start! As for testing, you should enable workflows and the create a new release here to trigger the workflow and artifact upload.
Done, and I found a bug in the workflow, which is also fixed with this MR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to respond, but looks great so far! Looking forward to adding it to the project.
9772a4c
to
3b28957
Compare
IMHO this is ready for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! This looks great, lmk if you want to see if we can simplify the code bit by handling most logic with file(DOWNLOAD)
or see flaws with my idea. Otherwise I'm also happy with merging this as is.
So, new try. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks again for the patience and updates!
The updated CPM download script has been released in v0.38.3! 🎉 |
This is a port from TheLartians/ModernCppStarter/pull/171. I have no idea if the workflow works correctly - tested it on my machine, but I couldn't figure out how to get this runner up on my fork. 😞