Treat relative paths as relative to parent project's remote #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLartians
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Hey, thanks for the pull request and even adding a test case!
I've refactored the test so it uses relative URLs defined in a different project (this branch of testpack-fibadder), so it won't break the tests on third-party forks of CPM.cmake.
After the change the test cases failed on CI, as it turns out the feature was introduced in CMake 3.27 but we were testing on 3.25 and 3.16. Not sure why they were previously passing, but we've updated our test runners and now seems to work fine.
|
Thanks for getting this merged! I realised it probably should have been an integration test instead of a unit-test but picked the easiest thing to copy/paste 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #520.