Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change action from docker to composite #83

Merged
merged 28 commits into from
Sep 1, 2022
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a030694
Change action from docker to composite
shenxianpeng Aug 11, 2022
c027b35
Change action from docker to composite
shenxianpeng Aug 11, 2022
061825a
re-organize action steps
2bndy5 Aug 12, 2022
d88abcc
shell is required for a composite action :-1:
2bndy5 Aug 12, 2022
f1de739
the python "shell" is an interactive REPL
2bndy5 Aug 12, 2022
15870fa
Add quotes to avoid misinterpret
shenxianpeng Aug 12, 2022
a37e9ff
Remove Dockerfile
shenxianpeng Aug 13, 2022
f20cbfa
Merge branch 'master' into composite-action
shenxianpeng Aug 19, 2022
38314c9
install cpp-linter pkg from PyPI
2bndy5 Aug 24, 2022
ff9b9e1
run test with files-changed-only = false
2bndy5 Aug 24, 2022
e2e66e1
remove composite step about action's output var
2bndy5 Aug 24, 2022
2c09969
reflect output var as exit code
2bndy5 Aug 24, 2022
33c9f67
remove FIXME comment
shenxianpeng Aug 27, 2022
4ba7b1a
update for testing
shenxianpeng Aug 27, 2022
afb3400
update for testing
shenxianpeng Aug 27, 2022
34c2386
change variable output value
shenxianpeng Aug 27, 2022
31438db
update variable output value
shenxianpeng Aug 27, 2022
5302ca9
change output variable
shenxianpeng Aug 27, 2022
15fdf2f
remove set variable step
shenxianpeng Aug 27, 2022
f564202
remove use as pkg from README
shenxianpeng Aug 27, 2022
0070d02
add what is new to README
shenxianpeng Aug 27, 2022
d7e93a3
don't show progress bars in clang-tools install
2bndy5 Aug 29, 2022
507d5a6
Remove publish-pypi.yml #91
shenxianpeng Aug 31, 2022
1e2ff28
Switch from master to main branch
shenxianpeng Aug 31, 2022
88eff0c
Add CONTRIBUTING.md
shenxianpeng Sep 1, 2022
d358972
Update CONTRIBUTING.md
shenxianpeng Sep 1, 2022
e4b25d4
Update CONTRIBUTING.md
shenxianpeng Sep 1, 2022
62eb603
requested changes
2bndy5 Sep 1, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cpp-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: cpp-linter/cpp-linter-action@master
- uses: cpp-linter/cpp-linter-action@composite-action
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
id: linter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
45 changes: 30 additions & 15 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,34 @@ inputs:
outputs:
checks-failed:
description: An integer that can be used as a boolean value to indicate if all checks failed.
value: ${{ steps.set-checks-failed.outputs.checks-failed }}
runs:
using: "docker"
image: "Dockerfile"
args:
- --style=${{ inputs.style }}
- --extensions=${{ inputs.extensions }}
- --tidy-checks=${{ inputs.tidy-checks }}
- --repo-root=${{ inputs.repo-root }}
- --version=${{ inputs.version }}
- --verbosity=${{ inputs.verbosity }}
- --lines-changed-only=${{ inputs.lines-changed-only }}
- --files-changed-only=${{ inputs.files-changed-only }}
- --thread-comments=${{ inputs.thread-comments }}
- --ignore=${{ inputs.ignore }}
- --database=${{ inputs.database }}
- --file-annotations=${{ inputs.file-annotations }}
using: "composite"
steps:
- name: Install action dependencies
# FIXME: when cpp-linter released to pypi, use that.
shell: bash
run: python3 -m pip install clang-tools git+https://github.com/cpp-linter/cpp-linter-action@v1
- name: Install clang-tools binary executables
shell: bash
run: clang-tools -i ${{ inputs.version }}
- name: Run cpp-linter
id: cpp-linter
shell: bash
run: |
cpp-linter \
--style="${{ inputs.style }}" \
--extensions=${{ inputs.extensions }} \
--tidy-checks="${{ inputs.tidy-checks }}" \
--repo-root=${{ inputs.repo-root }} \
--version=${{ inputs.version }} \
--verbosity=${{ inputs.verbosity }} \
--lines-changed-only=${{ inputs.lines-changed-only }} \
--files-changed-only=${{ inputs.files-changed-only }} \
--thread-comments=${{ inputs.thread-comments }} \
--ignore="${{ inputs.ignore }}" \
--database=${{ inputs.database }} \
--file-annotations=${{ inputs.file-annotations }}
- name: set output variable
shell: bash
shenxianpeng marked this conversation as resolved.
Show resolved Hide resolved
run: echo "::set-output name=checks-failed::"
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved