Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review dom::String for literal #413

Closed
vinniefalco opened this issue Jul 15, 2023 · 0 comments · Fixed by #444
Closed

review dom::String for literal #413

vinniefalco opened this issue Jul 15, 2023 · 0 comments · Fixed by #444
Assignees
@sdkrystian

Comments

@vinniefalco
Copy link
Member

dom::String is supposed to detect construction from string literals and handle them specially. This code and API needs to be reviewed for correctness. And also if it can be made more robust (are there any cases where it is UB or leads to unsafe behavior?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdkrystian sdkrystian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store dom::String as a single pointer sdkrystian/mrdocs
2 participants
@vinniefalco @sdkrystian