feat: 노드 생성 버튼 구현 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Coalery
commented
Aug 13, 2024
Coalery
commented
- 노드 생성 버튼을 구현합니다.
- label은 현재 랜덤 생성이며 이후 상황에 따라 수정될 수 있습니다.
Coalery
commented
Aug 13, 2024
| @@ -1,22 +1,24 @@ | |||
| /// <reference path="../types/diagram.d.ts" /> | |||
There was a problem hiding this comment.
맨 위에 있어야 reference가 의도대로 동작하여 옮겼습니다.
Coalery
commented
Aug 13, 2024
Comment on lines
+30
to
+31
| const mermaidElement = document.getElementById("diagram-canvas"); | ||
| mermaidElement.removeAttribute("data-processed"); |
There was a problem hiding this comment.
최초 호출되는 mermaid.run()에 의해 'data-processed' attribute가 mermaid element에 생성이 되어, 이후 mermaid.run()을 재호출해도 렌더링되지 않는 문제가 있습니다. 관련 코드
이를 해결하기 위해 'data-processed' attribute를 제거합니다.
ref:
Coalery
commented
Aug 13, 2024
There was a problem hiding this comment.
canvas용 별도 css 파일로 분리합니다. (canvas.css)
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.