Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gut static accessors implementation details #4

Closed
cpriest opened this issue Dec 28, 2012 · 4 comments
Closed

Gut static accessors implementation details #4

cpriest opened this issue Dec 28, 2012 · 4 comments
Assignees
@cpriest
Labels
todo

Comments

@cpriest
Copy link
Owner

cpriest commented Dec 28, 2012

The current static accessors implementation will not work properly for all use cases, the changes put in place to allow what does work (along with tests) need to be removed.
@ghost ghost assigned cpriest Dec 28, 2012
@cpriest
Copy link
Owner Author

cpriest commented Dec 28, 2012

Static accessors will be put on hold for a future revision to accessors.

@cpriest
Copy link
Owner Author

cpriest commented Dec 31, 2012

Holding off on this one until some other changes are made. (disallow conflict of static $foo and accessor $foo)

@cpriest
Copy link
Owner Author

cpriest commented Jan 2, 2013

Working on this one now.

@cpriest
Copy link
Owner Author

cpriest commented Jan 2, 2013

Fixed by ea327ea

@cpriest cpriest closed this as completed Jan 2, 2013
cpriest pushed a commit that referenced this issue Jan 19, 2013
Removed code related to static accessors
ea327ea 
This code was deemed to not work in all instances because the parent
class definition is not always available at line-compile time
fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpriest cpriest

Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cpriest