Skip to content

Commit

Permalink
Cargo: activate aws-lc-rs prebuilt-nasm feature
Browse files Browse the repository at this point in the history
Upstream Rustls has done this since 0.23.13. This feature makes
aws-lc-rs more like Ring w.r.t to its ASM artifacts on Windows and
allows removing the NASM install in CI.
  • Loading branch information
cpu committed Nov 2, 2024
1 parent b5a758c commit fc04aaf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,6 @@ jobs:
with:
toolchain: ${{ matrix.rust_channel }}

- name: Install NASM for aws-lc-rs on Windows
if: runner.os == 'Windows'
uses: ilammy/setup-nasm@v1

- name: Install ninja-build tool for aws-lc-fips-sys on Windows
if: runner.os == 'Windows'
uses: seanmiddleditch/gha-setup-ninja@v5
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ ring = ["dep:ring"]
std = ["alloc", "pki-types/std"]

[dependencies]
aws-lc-rs = { version = "1.9", optional = true, default-features = false, features = ["aws-lc-sys"] }
aws-lc-rs = { version = "1.9", optional = true, default-features = false, features = ["aws-lc-sys", "prebuilt-nasm"] }
pki-types = { package = "rustls-pki-types", version = "1.7", default-features = false }
ring = { version = "0.17", default-features = false, optional = true }
untrusted = "0.9"
Expand Down

0 comments on commit fc04aaf

Please sign in to comment.